Skip to content

: constant fold None #10755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

: constant fold None #10755

wants to merge 1 commit into from

Conversation

@ThomasJannaud
Copy link
Contributor

@ThomasJannaud ThomasJannaud commented May 7, 2025

Summary: Constant folding should fold 'None' and consider it a constant

Differential Revision: D74280168

@pytorch-bot
Copy link

pytorch-bot bot commented May 7, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10755

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures

As of commit 92cd06d with merge base ee6cf99 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 7, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 7, 2025

This pull request was exported from Phabricator. Differential Revision: D74280168

@github-actions
Copy link

github-actions bot commented May 7, 2025

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

ThomasJannaud added a commit to ThomasJannaud/executorch that referenced this pull request May 7, 2025
@ThomasJannaud @facebook-github-bot
: constant fold None (pytorch#10755)
d1a7f97 
Summary:

Constant folding should fold 'None' and consider it a constant

Reviewed By: dulinriley

Differential Revision: D74280168
@ThomasJannaud @facebook-github-bot
constant fold None (pytorch#10755)
92cd06d 
Summary:
Pull Request resolved: pytorch#10755

Constant folding should fold 'None' and consider it a constant

Reviewed By: dulinriley

Differential Revision: D74280168
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 7, 2025

This pull request was exported from Phabricator. Differential Revision: D74280168

@JacobSzwejbka
Copy link
Contributor

JacobSzwejbka commented Aug 13, 2025

Sorry for the late review. Can you add some context on this? Does const_prop not trigger if one of the args is None? Can you add a unit test that wouldve failed before this change?

@github-actions
Copy link

github-actions bot commented Oct 12, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Oct 12, 2025
@ThomasJannaud
Copy link
Contributor Author

ThomasJannaud commented Nov 10, 2025

closed in favor of #10762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@tarun292 tarun292 Awaiting requested review from tarun292

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported stale PRs inactive for over 60 days

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ThomasJannaud @facebook-github-bot @JacobSzwejbka